From 18ac7e39ad1afb0eef6d19f2e826d15894990d84 Mon Sep 17 00:00:00 2001
From: tdgao <mr.trumgao@gmail.com>
Date: Sat, 4 Jul 2026 14:38:20 -0700
Subject: [PATCH] feat: only show duplicate tooltip if there are duplicates

---
 .../DownloadDependencies.vue                  | 20 ++++++++++++++++++-
 1 file changed, 19 insertions(+), 1 deletion(-)

diff --git a/apps/frontend/src/components/ui/ProjectDownloadModal/DownloadDependencies.vue b/apps/frontend/src/components/ui/ProjectDownloadModal/DownloadDependencies.vue
index 184e9c92f9..d70ae48c27 100644
--- a/apps/frontend/src/components/ui/ProjectDownloadModal/DownloadDependencies.vue
+++ b/apps/frontend/src/components/ui/ProjectDownloadModal/DownloadDependencies.vue
@@ -4,7 +4,7 @@
 			<h3 class="m-0 flex items-center gap-1.5 text-base font-semibold text-contrast">
 				{{ sectionTitle }}
 				<InfoIcon
-					v-if="visibleDependencyRows.length > 0"
+					v-if="duplicateDependencyRowsHidden"
 					v-tooltip="formatMessage(messages.duplicateDependenciesHidden)"
 					aria-hidden="true"
 					class="size-4 text-secondary"
@@ -253,6 +253,10 @@ const visibleDependencyRows = computed<DownloadDependencyRow[]>(() =>
 	dedupeDependencyRows(dependencyRows.value),
 )
 
+const duplicateDependencyRowsHidden = computed(() =>
+	hasDuplicateDependencyRows(dependencyRows.value),
+)
+
 const additionalFileRows = computed<DownloadDependencyRow[]>(() =>
 	props.additionalFiles.map((file) => ({
 		key: `additional-file-${additionalFileKey(file)}`,
@@ -396,6 +400,20 @@ function dependencyRowIdentity(row: DownloadDependencyRow) {
 	return row.projectHref ?? row.downloadHref ?? row.key
 }
 
+function hasDuplicateDependencyRows(
+	rows: DownloadDependencyRow[],
+	seenDependencies = new Set<string>(),
+): boolean {
+	for (const row of rows) {
+		const rowId = dependencyRowIdentity(row)
+		if (seenDependencies.has(rowId)) return true
+		seenDependencies.add(rowId)
+		if (hasDuplicateDependencyRows(row.dependencies, seenDependencies)) return true
+	}
+
+	return false
+}
+
 function collectDownloadableDependencyFiles(
 	rows: DownloadDependencyRow[],
 	seenHrefs = new Set<string>(),