sugoidogo/modrinth
1
0
Fork 0
mirror of https://github.com/modrinth/code.git synced 2026-09-05 06:19:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(app-lib): treat all errors as missing icon (#7333)

Browse Source 
* fix(app-lib): treat all errors as missing icon

* style(app-lib): cargo fmt
This commit is contained in:
Sychic
2026-08-27 16:37:30 +00:00
committed by GitHub
parent 25fb06ce27
commit 2bd108c278
1 changed files with 2 additions and 15 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/app-lib/src/state/instances/commands/create_instance.rs
+2 -15
View File
@@ -200,9 +200,8 @@ pub(crate) async fn resolve_icon_path(
.await .await
{ {
Ok(bytes) => bytes, Ok(bytes) => bytes,
Err(error) Err(error) if ignore_missing_remote_icon => {
if ignore_missing_remote_icon && is_not_found_error(&error) => tracing::warn!("Error while getting instance icon: {error}");
{
return Ok(None); return Ok(None);
} }
Err(error) => return Err(error), Err(error) => return Err(error),
@@ -219,18 +218,6 @@ pub(crate) async fn resolve_icon_path(
Ok(Some(file.to_string_lossy().to_string())) Ok(Some(file.to_string_lossy().to_string()))
} }
fn is_not_found_error(error: &crate::Error) -> bool {
match error.raw.as_ref() {
crate::ErrorKind::FetchError(error) => {
error.status() == Some(reqwest::StatusCode::NOT_FOUND)
}
crate::ErrorKind::LabrinthError(error) => {
error.status == Some(reqwest::StatusCode::NOT_FOUND.as_u16())
}
_ => false,
}
}
fn content_source_kind(link: &InstanceLink) -> ContentSourceKind { fn content_source_kind(link: &InstanceLink) -> ContentSourceKind {
match link { match link {
InstanceLink::Unmanaged => ContentSourceKind::Local, InstanceLink::Unmanaged => ContentSourceKind::Local,