fix: version tags toggling every supported version and freezing the page (#6967)

Fixes #6601.

Clicking any game version tag on the versions tab passed the release's
entire game_versions array to toggleFilters, so clicking 26.x (or even a
single version tag) selected every version the release supports. On
projects supporting many versions this also froze the page for seconds:
toggleFilters awaited a needlessly-async toggleFilter per version, which
let Vue flush a full re-render between every iteration (~90 flushes on
the reported project).

- formatVersionsForDisplay's grouping now also returns the member
  versions per displayed range (getVersionGroupsForDisplay), so version
  tags toggle exactly the versions they represent
- toggleFilters applies the whole batch synchronously in one update, and
  selects the missing versions unless all are already selected (instead
  of blindly inverting each one)

Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
LarpinWBD
2026-08-04 21:12:57 +00:00
committed by GitHub
co-authored by Claude
parent bb2193b6f5
commit 3487523f74
3 changed files with 110 additions and 67 deletions
+49 -25
View File
@@ -66,6 +66,11 @@ export type PlatformTag = {
supported_project_types: DisplayProjectType[]
}
export type VersionDisplayGroup = {
label: string
versions: string[]
}
export function getVersionsToDisplay(project, allGameVersions: GameVersionTag[]) {
return formatVersionsForDisplay(project.game_versions.slice(), allGameVersions)
}
@@ -74,6 +79,13 @@ export function formatVersionsForDisplay(
gameVersions: string[],
allGameVersions: GameVersionTag[],
) {
return getVersionGroupsForDisplay(gameVersions, allGameVersions).map((group) => group.label)
}
export function getVersionGroupsForDisplay(
gameVersions: string[],
allGameVersions: GameVersionTag[],
): VersionDisplayGroup[] {
const inputVersions = gameVersions.slice()
const allVersions = allGameVersions.slice()
@@ -112,26 +124,33 @@ export function formatVersionsForDisplay(
)
const projectVersionsGrouped = groupVersions(releaseVersions, true)
const releaseVersionsAsRanges = projectVersionsGrouped.map(({ major, minor }) => {
if (minor.length === 1) {
return formatMinecraftMinorVersion(major, minor[0])
}
const releaseVersionsAsRanges: VersionDisplayGroup[] = projectVersionsGrouped.map(
({ major, minor }) => {
const versions = minor.map((minorVersion) => formatMinecraftMinorVersion(major, minorVersion))
const range = allReleasesGrouped.find((x) => x.major === major)
if (minor.length === 1) {
return { label: versions[0], versions }
}
if (range?.minor.every((value, index) => value === minor[index])) {
return `${major}.x`
}
const range = allReleasesGrouped.find((x) => x.major === major)
return `${formatMinecraftMinorVersion(major, minor[0])}${formatMinecraftMinorVersion(major, minor[minor.length - 1])}`
})
if (range?.minor.every((value, index) => value === minor[index])) {
return { label: `${major}.x`, versions }
}
return {
label: `${formatMinecraftMinorVersion(major, minor[0])}${formatMinecraftMinorVersion(major, minor[minor.length - 1])}`,
versions,
}
},
)
const legacyVersionsAsRanges = groupConsecutiveIndices(
inputVersions.filter((projVer) => allLegacy.some((gameVer) => gameVer.version === projVer)),
allLegacy,
)
let output = [...legacyVersionsAsRanges]
let output: VersionDisplayGroup[] = [...legacyVersionsAsRanges]
// show all snapshots if there's no release versions
if (releaseVersionsAsRanges.length === 0) {
@@ -141,14 +160,14 @@ export function formatVersionsForDisplay(
const snapshotVersionsAsRanges =
snapshotVersions.length > 3
? groupConsecutiveIndices(snapshotVersions, allSnapshots)
: snapshotVersions
: snapshotVersions.map((version) => ({ label: version, versions: [version] }))
output = [...snapshotVersionsAsRanges, ...output]
} else {
output = [...releaseVersionsAsRanges, ...output]
}
if (releaseVersionsAsRanges.length > 0 && latestSnapshot) {
output = [latestSnapshot, ...output]
output = [{ label: latestSnapshot, versions: [latestSnapshot] }, ...output]
}
return output
}
@@ -188,7 +207,10 @@ function groupVersions(versions: string[], consecutive = false) {
.reverse()
}
function groupConsecutiveIndices(versions: string[], referenceList: GameVersionTag[]) {
function groupConsecutiveIndices(
versions: string[],
referenceList: GameVersionTag[],
): VersionDisplayGroup[] {
if (!versions || versions.length === 0) {
return []
}
@@ -202,21 +224,23 @@ function groupConsecutiveIndices(versions: string[], referenceList: GameVersionT
.slice()
.sort((a, b) => referenceMap.get(a) - referenceMap.get(b))
const ranges: string[] = []
let start = sortedList[0]
let previous = sortedList[0]
const ranges: VersionDisplayGroup[] = []
let rangeStartIndex = 0
for (let i = 1; i < sortedList.length; i++) {
const current = sortedList[i]
if (referenceMap.get(current) !== referenceMap.get(previous) + 1) {
ranges.push(validateRange(`${previous}${start}`))
start = current
for (let i = 1; i <= sortedList.length; i++) {
if (
i === sortedList.length ||
referenceMap.get(sortedList[i]) !== referenceMap.get(sortedList[i - 1]) + 1
) {
const members = sortedList.slice(rangeStartIndex, i)
ranges.push({
label: validateRange(`${members[members.length - 1]}${members[0]}`),
versions: members,
})
rangeStartIndex = i
}
previous = current
}
ranges.push(validateRange(`${previous}${start}`))
return ranges
}