From 4b2f8dedec0b9d034c1fd84e46d2c93e0747d520 Mon Sep 17 00:00:00 2001 From: chyz <32403637+chyzman@users.noreply.github.com> Date: Mon, 24 Aug 2026 17:23:12 -0400 Subject: [PATCH] Better External Link Validation (#7005) * complain about links we know are incorrect * dont complain about the specific part of the url being incorrect if it wouldn't be correct regardless * UnsavedChangesPopup had a place where it was supposed to disable the save button but the actual impl didn't implement that property so i fixed that and also more work on link checks (including start of license link checks too) * github sponsor note * show the warning directly cuz it's not particularly clear there's a tooltip migrate links page to actually good unsaved changes thing that every other page uses also like self-hosted git support also add 9minecraft to blacklist * this dont look correct warning + oops duplicate id * better/more blacklist * clean up after merge * imports --------- Co-authored-by: tdgao --- .../src/components/LinkCheckMessage.vue | 29 + .../[type]/[project]/settings/license.vue | 18 +- .../pages/[type]/[project]/settings/links.vue | 524 ++++++------ packages/moderation/src/data/nags/index.ts | 1 + .../moderation/src/data/nags/link-checks.ts | 749 ++++++++++++++++++ 5 files changed, 1043 insertions(+), 278 deletions(-) create mode 100644 apps/frontend/src/components/LinkCheckMessage.vue create mode 100644 packages/moderation/src/data/nags/link-checks.ts diff --git a/apps/frontend/src/components/LinkCheckMessage.vue b/apps/frontend/src/components/LinkCheckMessage.vue new file mode 100644 index 0000000000..d273bef595 --- /dev/null +++ b/apps/frontend/src/components/LinkCheckMessage.vue @@ -0,0 +1,29 @@ + + + diff --git a/apps/frontend/src/pages/[type]/[project]/settings/license.vue b/apps/frontend/src/pages/[type]/[project]/settings/license.vue index fea81bc4ff..9d6079b9b2 100644 --- a/apps/frontend/src/pages/[type]/[project]/settings/license.vue +++ b/apps/frontend/src/pages/[type]/[project]/settings/license.vue @@ -72,7 +72,7 @@ -
+
+
@@ -145,7 +146,8 @@ !( current.license.friendly === 'Custom' && (current.license.short === '' || current.licenseUrl === '') - ) + ) && + effectiveLicenseCheck?.severity !== 'error' " @reset="reset" @save="save" @@ -154,6 +156,7 @@