From 4eeb52eafd38973742ea251c13db431e09cc3386 Mon Sep 17 00:00:00 2001
From: tdgao <mr.trumgao@gmail.com>
Date: Fri, 3 Jul 2026 15:21:10 -0700
Subject: [PATCH] feat: add tooltip for downloading file with filename and size

---
 .../DownloadDependencies.vue                  |  3 ++
 .../DownloadDependency.vue                    | 45 ++++++++++++++++---
 apps/frontend/src/locales/en-US/index.json    |  6 +++
 3 files changed, 49 insertions(+), 5 deletions(-)

diff --git a/apps/frontend/src/components/ui/ProjectDownloadModal/DownloadDependencies.vue b/apps/frontend/src/components/ui/ProjectDownloadModal/DownloadDependencies.vue
index ad6b4ba2a9..184e9c92f9 100644
--- a/apps/frontend/src/components/ui/ProjectDownloadModal/DownloadDependencies.vue
+++ b/apps/frontend/src/components/ui/ProjectDownloadModal/DownloadDependencies.vue
@@ -57,6 +57,7 @@ interface DownloadDependencyRow {
 	projectHref?: string
 	downloadHref?: string
 	filename?: string
+	fileSize?: number
 	typeLabel: string
 	unavailableTooltip: string
 	dependencies: DownloadDependencyRow[]
@@ -259,6 +260,7 @@ const additionalFileRows = computed<DownloadDependencyRow[]>(() =>
 		fallbackIcon: FileIcon,
 		downloadHref: getDownloadUrl(file.url),
 		filename: file.filename,
+		fileSize: file.size,
 		typeLabel: fileTypeLabel(file.file_type),
 		unavailableTooltip: formatMessage(messages.unavailableFile),
 		dependencies: [],
@@ -323,6 +325,7 @@ function createDependencyRow(dependency: ResolvedContent): DownloadDependencyRow
 		downloadHref:
 			'reason' in dependency || !primaryFile ? undefined : getDownloadUrl(primaryFile.url),
 		filename: primaryFile?.filename,
+		fileSize: primaryFile?.size,
 		typeLabel: 'Required',
 		unavailableTooltip,
 		dependencies: (versionId && dependenciesByParentVersionId.value.get(versionId)
diff --git a/apps/frontend/src/components/ui/ProjectDownloadModal/DownloadDependency.vue b/apps/frontend/src/components/ui/ProjectDownloadModal/DownloadDependency.vue
index 02ce80e1d2..840d4ff35e 100644
--- a/apps/frontend/src/components/ui/ProjectDownloadModal/DownloadDependency.vue
+++ b/apps/frontend/src/components/ui/ProjectDownloadModal/DownloadDependency.vue
@@ -46,10 +46,10 @@
 			</span>
 			<ButtonStyled v-if="dependency.downloadHref" circular type="transparent">
 				<a
-					v-tooltip="'Download'"
+					v-tooltip="downloadTooltip"
 					:href="dependency.downloadHref"
 					:download="dependency.filename"
-					:aria-label="`Download ${dependency.name}`"
+					:aria-label="downloadTooltip"
 					@click="emit('download')"
 				>
 					<DownloadIcon aria-hidden="true" class="size-6 text-secondary" />
@@ -82,8 +82,16 @@
 
 <script setup lang="ts">
 import { DownloadIcon, PackageIcon } from '@modrinth/assets'
-import { Avatar, ButtonStyled, TagItem, truncatedTooltip } from '@modrinth/ui'
-import { type Component, ref } from 'vue'
+import {
+	Avatar,
+	ButtonStyled,
+	defineMessages,
+	TagItem,
+	truncatedTooltip,
+	useFormatBytes,
+	useVIntl,
+} from '@modrinth/ui'
+import { computed, type Component, ref } from 'vue'
 
 defineOptions({
 	name: 'DownloadDependency',
@@ -97,12 +105,13 @@ interface DownloadDependencyRow {
 	projectHref?: string
 	downloadHref?: string
 	filename?: string
+	fileSize?: number
 	typeLabel: string
 	unavailableTooltip: string
 	dependencies: DownloadDependencyRow[]
 }
 
-defineProps<{
+const props = defineProps<{
 	dependency: DownloadDependencyRow
 }>()
 
@@ -110,5 +119,31 @@ const emit = defineEmits<{
 	download: []
 }>()
 
+const { formatMessage } = useVIntl()
+const formatBytes = useFormatBytes()
 const dependencyNameRef = ref<HTMLElement | null>(null)
+
+const downloadTooltip = computed(() => {
+	const filename = props.dependency.filename || props.dependency.name
+
+	if (typeof props.dependency.fileSize === 'number') {
+		return formatMessage(messages.downloadFileWithSize, {
+			filename,
+			size: formatBytes(props.dependency.fileSize, 1),
+		})
+	}
+
+	return formatMessage(messages.downloadFile, { filename })
+})
+
+const messages = defineMessages({
+	downloadFile: {
+		id: 'project.download.dependency-download-file',
+		defaultMessage: 'Download {filename}',
+	},
+	downloadFileWithSize: {
+		id: 'project.download.dependency-download-file-with-size',
+		defaultMessage: 'Download {filename} ({size})',
+	},
+})
 </script>
diff --git a/apps/frontend/src/locales/en-US/index.json b/apps/frontend/src/locales/en-US/index.json
index 8d875a512e..05ba61131e 100644
--- a/apps/frontend/src/locales/en-US/index.json
+++ b/apps/frontend/src/locales/en-US/index.json
@@ -3254,6 +3254,12 @@
   "project.download.dependency-conflicting": {
     "message": "This dependency conflicts with another dependency"
   },
+  "project.download.dependency-download-file": {
+    "message": "Download {filename}"
+  },
+  "project.download.dependency-download-file-with-size": {
+    "message": "Download {filename} ({size})"
+  },
   "project.download.dependency-duplicate": {
     "message": "This dependency is already included"
   },