sugoidogo/modrinth
1
0
Fork 0
mirror of https://github.com/modrinth/code.git synced 2026-08-26 17:44:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: file attribution scanning not marking completed files (#6500)

Browse Source 
* fix: file attribution scanning not marking completed files

* Clean up unused attribution files/groups on deletion

* prepare

* Handle file scan failures gracefully with tracking
This commit is contained in:
aecsocket
2026-06-25 15:57:51 +00:00
committed by GitHub
parent f4a2999b20
commit 527757d158
16 changed files with 215 additions and 182 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/labrinth/src/database/models/version_item.rs
+20 -3
View File
@@ -25,16 +25,33 @@ use tracing::error;
pub const VERSIONS_NAMESPACE: &str = "versions";
const VERSION_FILES_NAMESPACE: &str = "versions_files";
pub async fn cleanup_empty_attribution_groups(
pub async fn cleanup_unused_attribution_files_and_groups(
transaction: &mut PgTransaction<'_>,
) -> Result<(), DatabaseError> {
sqlx::query!(
"
DELETE FROM project_attribution_files paf
USING project_attribution_groups pag
WHERE pag.id = paf.group_id
AND NOT EXISTS (
SELECT 1
FROM override_file_sources ofs
INNER JOIN files f ON f.id = ofs.file_id
INNER JOIN versions v ON v.id = f.version_id
WHERE ofs.sha1 = paf.sha1
AND v.mod_id = pag.project_id
)
",
)
.execute(&mut *transaction)
.await?;
sqlx::query!(
"
DELETE FROM project_attribution_groups g
WHERE NOT EXISTS (
SELECT 1
FROM project_attribution_files paf
INNER JOIN override_file_sources ofs ON ofs.sha1 = paf.sha1
WHERE paf.group_id = g.id
)
",
@@ -493,7 +510,7 @@ impl DBVersion {
.execute(&mut *transaction)
.await?;
cleanup_empty_attribution_groups(transaction).await?;
cleanup_unused_attribution_files_and_groups(transaction).await?;
// Sync dependencies