sugoidogo/modrinth
1
0
Fork 0
mirror of https://github.com/modrinth/code.git synced 2026-08-25 00:55:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(labrinth): fix filtering not working unless breakdown set to same field (#6608)

Browse Source 
* fix(labrinth): return columns used in filters

fixes modrinth/code#6607

* chore(labrinth): sqlx query data update

* don't implicitly breakdown when filtering by a metric

* fix docs

---------

Co-authored-by: aecsocket <43144841+aecsocket@users.noreply.github.com>
This commit is contained in:
penguinencounter
2026-07-12 11:31:56 +02:00
committed by GitHub
co-authored by aecsocket
parent e1556a8ee3
commit 7c4df7442b
5 changed files with 120 additions and 24 deletions
Download Patch File Download Diff File Expand all files Collapse all files
apps/frontend/src/providers/analytics/analytics-filter-utils.ts
+10 -7
View File
@@ -430,7 +430,7 @@ function getCountryFilterValue(
return undefined
}
return dataPoint.country ?? null
return 'country' in dataPoint ? (dataPoint.country ?? null) : undefined
}
function getMonetizationFilterValue(
@@ -439,6 +439,9 @@ function getMonetizationFilterValue(
if (dataPoint.metric_kind !== 'views' && dataPoint.metric_kind !== 'downloads') {
return undefined
}
if (!('monetized' in dataPoint)) {
return undefined
}
if (typeof dataPoint.monetized !== 'boolean') {
return null
}
@@ -463,7 +466,7 @@ function getDownloadSourceFilterValue(
return undefined
}
return dataPoint.user_agent ?? null
return 'user_agent' in dataPoint ? (dataPoint.user_agent ?? null) : undefined
}
function getDownloadReasonFilterValue(
@@ -473,7 +476,7 @@ function getDownloadReasonFilterValue(
return undefined
}
return dataPoint.reason ?? null
return 'reason' in dataPoint ? (dataPoint.reason ?? null) : undefined
}
function getUserIdFilterValue(
@@ -483,7 +486,7 @@ function getUserIdFilterValue(
return undefined
}
return dataPoint.user_id ?? null
return 'user_id' in dataPoint ? (dataPoint.user_id ?? null) : undefined
}
function getVersionFilterValue(
@@ -493,7 +496,7 @@ function getVersionFilterValue(
return undefined
}
return dataPoint.version_id ?? null
return 'version_id' in dataPoint ? (dataPoint.version_id ?? null) : undefined
}
function getGameVersionFilterValue(
@@ -503,7 +506,7 @@ function getGameVersionFilterValue(
return undefined
}
return dataPoint.game_version ?? null
return 'game_version' in dataPoint ? (dataPoint.game_version ?? null) : undefined
}
function getLoaderFilterValue(
@@ -513,5 +516,5 @@ function getLoaderFilterValue(
return undefined
}
return dataPoint.loader ?? null
return 'loader' in dataPoint ? (dataPoint.loader ?? null) : undefined
}