sugoidogo/modrinth
1
0
Fork 0
mirror of https://github.com/modrinth/code.git synced 2026-09-04 05:48:57 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix(skins): translucency issues with outer layer (#6345)

Browse Source 
fix(skins): translucency issues with outer layer in main renderer
This commit is contained in:
Calum H.
2026-06-10 13:28:21 +00:00
committed by GitHub
parent 180cef6eaa
commit 98b1730e19
2 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
packages/ui/src/composables/skin-rendering/use-skin-preview-scene.ts
+1 -1
View File
@@ -32,7 +32,7 @@ function configureSkinPreviewMesh(mesh: THREE.Mesh) {
materials.forEach((material) => { materials.forEach((material) => {
if (!(material instanceof THREE.MeshStandardMaterial) || material.name === 'cape') return if (!(material instanceof THREE.MeshStandardMaterial) || material.name === 'cape') return
material.transparent = false material.transparent = isSkinLayer
material.alphaTest = 0.1 material.alphaTest = 0.1
material.depthTest = true material.depthTest = true
material.depthWrite = true material.depthWrite = true
packages/ui/src/utils/webgl/skin-rendering.ts
+2 -1
View File
@@ -157,6 +157,7 @@ export function applyTexture(model: THREE.Object3D, texture: THREE.Texture): voi
model.traverse((child) => { model.traverse((child) => {
if ((child as THREE.Mesh).isMesh) { if ((child as THREE.Mesh).isMesh) {
const mesh = child as THREE.Mesh const mesh = child as THREE.Mesh
const isSkinLayer = mesh.name.endsWith('_Layer')
const materials = Array.isArray(mesh.material) ? mesh.material : [mesh.material] const materials = Array.isArray(mesh.material) ? mesh.material : [mesh.material]
materials.forEach((mat: THREE.Material) => { materials.forEach((mat: THREE.Material) => {
@@ -168,7 +169,7 @@ export function applyTexture(model: THREE.Object3D, texture: THREE.Texture): voi
flatShading: true, flatShading: true,
side: THREE.FrontSide, side: THREE.FrontSide,
toneMapped: false, toneMapped: false,
transparent: false, transparent: isSkinLayer,
}) })
setCommonMaterialProperties(mat) setCommonMaterialProperties(mat)