fix: handling failures/invalid popup edge cases to show normal gdpr popup fallback (#6857)

* fix: remove drilling actions down iframes

* refactor: split up custom popup logic, trim it down a lot

* fix: bring back TCF useractioncomplete and USP/GPP sectionChange event listeners, and only using dom observer as the fallback

* remove open devtools

* format

* harden CPM fallbacks for unknown layouts

* consolidate timeouts

* refactor: rename functions to make sense

* fix: sidebar closed on launch does not properly set state

apps/app-frontend/src/App.vue

@@ -93,10 +93,10 @@ import { useCheckDisableMouseover } from '@/composables/macCssFix.js'
 import { config } from '@/config'
 import {
 	ads_consent_listener,
-	get_ads_consent_required,
 	hide_ads_window,
 	init_ads_window,
 	perform_ads_consent_action,
+	should_show_ads_consent_popup,
 	show_ads_window,
 } from '@/helpers/ads.js'
 import { debugAnalytics, initAnalytics, trackEvent } from '@/helpers/analytics'
@@ -339,7 +339,7 @@ onMounted(async () => {
 	await useCheckDisableMouseover()
 	try {
 		unlistenAdsConsent = await ads_consent_listener(handleAdsConsentRequired)
-		handleAdsConsentRequired(await get_ads_consent_required())
+		handleAdsConsentRequired(await should_show_ads_consent_popup())
 	} catch (error) {
 		handleError(error)
 	}

apps/app-frontend/src/helpers/ads.js

@@ -16,8 +16,8 @@ export async function hide_ads_window(reset) {
 	return await invoke('plugin:ads|hide_ads_window', { reset })
 }
 
-export async function get_ads_consent_required() {
-	return await invoke('plugin:ads|get_ads_consent_required')
+export async function should_show_ads_consent_popup() {
+	return await invoke('plugin:ads|should_show_ads_consent_popup')
 }
 
 export async function perform_ads_consent_action(action) {