feat: global trace database frontend + improvements to tech review status sync (#6671)

* wip * ui edits * better logic for syncing tech review state in a single centralized place * never automatically finish a tech review report * fix css * fix clippy * prepr
2026-08-25 00:55:25 +00:00 · 2026-07-09 16:09:02 +00:00
parent 623b51e6ea
commit e877167db7
29 changed files with 1369 additions and 396 deletions
@@ -0,0 +1,29 @@
+{
+  "db_name": "PostgreSQL",
+  "query": "\n        SELECT\n            (\n                SELECT t.id\n                FROM threads t\n                WHERE t.mod_id = $1\n                ORDER BY t.id\n                LIMIT 1\n            ) AS \"thread_id: DBThreadId\",\n            (\n                SELECT tm.body->>'type'\n                FROM threads t\n                INNER JOIN threads_messages tm ON tm.thread_id = t.id\n                WHERE\n                    t.mod_id = $1\n                    AND tm.body->>'type' = ANY($2::text[])\n                ORDER BY tm.created DESC, tm.id DESC\n                LIMIT 1\n            ) AS \"last_tech_review_message_type\"\n        ",
+  "describe": {
+    "columns": [
+      {
+        "ordinal": 0,
+        "name": "thread_id: DBThreadId",
+        "type_info": "Int8"
+      },
+      {
+        "ordinal": 1,
+        "name": "last_tech_review_message_type",
+        "type_info": "Text"
+      }
+    ],
+    "parameters": {
+      "Left": [
+        "Int8",
+        "TextArray"
+      ]
+    },
+    "nullable": [
+      null,
+      null
+    ]
+  },
+  "hash": "080e2f0068c0c1c248dcfacf39798aefed70d9a61610fc7f4f1c8f291706fa4a"
+}
@@ -1,28 +0,0 @@
-{
-  "db_name": "PostgreSQL",
-  "query": "\n        SELECT\n            EXISTS(\n                SELECT 1 FROM delphi_issue_details_with_statuses didws\n                WHERE didws.project_id = $1 AND didws.status = 'pending'\n            ) AS \"pending_issue_details_exist!\",\n            t.id AS \"thread_id: DBThreadId\"\n        FROM mods m\n        INNER JOIN threads t ON t.mod_id = $1\n        ",
-  "describe": {
-    "columns": [
-      {
-        "ordinal": 0,
-        "name": "pending_issue_details_exist!",
-        "type_info": "Bool"
-      },
-      {
-        "ordinal": 1,
-        "name": "thread_id: DBThreadId",
-        "type_info": "Int8"
-      }
-    ],
-    "parameters": {
-      "Left": [
-        "Int8"
-      ]
-    },
-    "nullable": [
-      null,
-      false
-    ]
-  },
-  "hash": "2d9e36c76a1e214c53d9dc2aa3debe1d03998be169a306b63a0ca1beaa07397f"
-}
@@ -1,6 +1,6 @@
 {
  "db_name": "PostgreSQL",
-  "query": "\n        SELECT DISTINCT ON (dr.id)\n            to_jsonb(dr)\n            || jsonb_build_object(\n                'report_id', dr.id,\n                'file_id', to_base62(f.id),\n                'version_id', to_base62(v.id),\n                'project_id', to_base62(v.mod_id),\n                'file_name', f.filename,\n                'file_size', f.size,\n                'flag_reason', 'delphi',\n                'download_url', f.url,\n                -- TODO: replace with `json_array` in Postgres 16\n\t\t\t\t'issues', (\n\t\t\t\t\tSELECT coalesce(json_agg(\n\t\t\t\t\t\tto_jsonb(dri)\n\t\t\t\t\t\t|| jsonb_build_object(\n\t\t\t\t\t\t\t-- TODO: replace with `json_array` in Postgres 16\n\t\t\t\t\t\t\t'details', (\n\t\t\t\t\t\t\t\tSELECT coalesce(jsonb_agg(\n                                    jsonb_build_object(\n                                        'id', didws.id,\n                                        'issue_id', didws.issue_id,\n                                        'key', didws.key,\n                                        'file_path', didws.file_path,\n                                        'decompiled_source', didws.decompiled_source,\n                                        'data', didws.data,\n                                        'severity', didws.severity,\n                                        'status', didws.status\n                                    )\n                                ), '[]'::jsonb)\n                                FROM delphi_issue_details_with_statuses didws\n                                WHERE didws.issue_id = dri.id\n                            )\n\t\t\t\t\t\t)\n\t\t\t\t\t), '[]'::json)\n\t\t\t\t\tFROM delphi_report_issues dri\n\t\t\t\t\tWHERE\n\t\t\t\t\t\tdri.report_id = dr.id\n                        -- see delphi.rs todo comment\n                        AND dri.issue_type != '__dummy'\n                )\n            ) AS \"data!: sqlx::types::Json<FileReport>\"\n        FROM delphi_reports dr\n        INNER JOIN files f ON f.id = dr.file_id\n        INNER JOIN versions v ON v.id = f.version_id\n        WHERE dr.id = $1\n        ",
+  "query": "\n        SELECT DISTINCT ON (dr.id)\n            to_jsonb(dr)\n            || jsonb_build_object(\n                'report_id', dr.id,\n                'file_id', to_base62(f.id),\n                'version_id', to_base62(v.id),\n                'project_id', to_base62(v.mod_id),\n                'file_name', f.filename,\n                'file_size', f.size,\n                'flag_reason', 'delphi',\n                'download_url', f.url,\n                -- TODO: replace with `json_array` in Postgres 16\n\t\t\t\t'issues', (\n\t\t\t\t\tSELECT coalesce(json_agg(\n\t\t\t\t\t\tto_jsonb(dri)\n\t\t\t\t\t\t|| jsonb_build_object(\n\t\t\t\t\t\t\t-- TODO: replace with `json_array` in Postgres 16\n\t\t\t\t\t\t\t'details', (\n\t\t\t\t\t\t\t\tSELECT coalesce(jsonb_agg(\n                                    jsonb_build_object(\n                                        'id', didws.id,\n                                        'issue_id', didws.issue_id,\n                                        'key', didws.key,\n                                        'file_path', didws.file_path,\n                                        'decompiled_source', didws.decompiled_source,\n                                        'data', didws.data,\n                                        'severity', didws.severity,\n                                        'local_status', didws.local_status,\n                                        'global_status', didws.global_status,\n                                        'status', didws.status\n                                    )\n                                ), '[]'::jsonb)\n                                FROM delphi_issue_details_with_statuses didws\n                                WHERE didws.issue_id = dri.id\n                            )\n\t\t\t\t\t\t)\n\t\t\t\t\t), '[]'::json)\n\t\t\t\t\tFROM delphi_report_issues dri\n\t\t\t\t\tWHERE\n\t\t\t\t\t\tdri.report_id = dr.id\n                        -- see delphi.rs todo comment\n                        AND dri.issue_type != '__dummy'\n                )\n            ) AS \"data!: sqlx::types::Json<FileReport>\"\n        FROM delphi_reports dr\n        INNER JOIN files f ON f.id = dr.file_id\n        INNER JOIN versions v ON v.id = f.version_id\n        WHERE dr.id = $1\n        ",
  "describe": {
    "columns": [
      {
@@ -18,5 +18,5 @@
      null
    ]
  },
-  "hash": "fe4ff6ab40fe3dc3d474c0c23c9dba514c66ac30e573fc5f4e44ed7ff360d3d6"
+  "hash": "48dfc2f2bcf8917f110b7b2b142167f1525cdea2ace9e6165e5c5f596cbd9fb3"
 }
@@ -1,22 +0,0 @@
-{
-  "db_name": "PostgreSQL",
-  "query": "\n        SELECT id AS \"thread_id: DBThreadId\"\n        FROM threads\n        WHERE mod_id = $1\n        LIMIT 1\n        ",
-  "describe": {
-    "columns": [
-      {
-        "ordinal": 0,
-        "name": "thread_id: DBThreadId",
-        "type_info": "Int8"
-      }
-    ],
-    "parameters": {
-      "Left": [
-        "Int8"
-      ]
-    },
-    "nullable": [
-      false
-    ]
-  },
-  "hash": "555342b0ec9fb808f05a18aaeaf06fb61e968fb3379c9d0c7ad82c8747bd4256"
-}
@@ -1,15 +0,0 @@
-{
-  "db_name": "PostgreSQL",
-  "query": "\n        WITH incoming AS (\n            SELECT *\n            FROM unnest($1::text[], $2::text[]) WITH ORDINALITY\n                AS u(detail_key, verdict, ord)\n        )\n        INSERT INTO delphi_global_detail_verdicts (\n            detail_key,\n            verdict\n        )\n        SELECT DISTINCT ON (detail_key)\n            detail_key,\n            verdict::delphi_report_issue_status\n        FROM incoming\n        ORDER BY detail_key, ord DESC\n        ON CONFLICT (detail_key)\n        DO UPDATE SET verdict = EXCLUDED.verdict\n        ",
-  "describe": {
-    "columns": [],
-    "parameters": {
-      "Left": [
-        "TextArray",
-        "TextArray"
-      ]
-    },
-    "nullable": []
-  },
-  "hash": "6402f359bbf733a9a2173f23c2ea222611fde49f692406123145dc6acd3dcd6a"
-}
@@ -0,0 +1,15 @@
+{
+  "db_name": "PostgreSQL",
+  "query": "\n        WITH incoming AS (\n            SELECT *\n            FROM unnest($1::text[], $2::text[]) WITH ORDINALITY\n                AS u(detail_key, verdict, ord)\n        ),\n        latest AS (\n            SELECT DISTINCT ON (detail_key)\n                detail_key,\n                verdict\n            FROM incoming\n            ORDER BY detail_key, ord DESC\n        ),\n        deleted AS (\n            DELETE FROM delphi_global_detail_verdicts dgdv\n            USING latest\n            WHERE\n                dgdv.detail_key = latest.detail_key\n                AND latest.verdict = 'pending'\n            RETURNING 1\n        )\n        INSERT INTO delphi_global_detail_verdicts (\n            detail_key,\n            verdict\n        )\n        SELECT\n            detail_key,\n            verdict::delphi_report_issue_status\n        FROM latest\n        WHERE verdict != 'pending'\n        ON CONFLICT (detail_key)\n        DO UPDATE SET verdict = EXCLUDED.verdict\n        ",
+  "describe": {
+    "columns": [],
+    "parameters": {
+      "Left": [
+        "TextArray",
+        "TextArray"
+      ]
+    },
+    "nullable": []
+  },
+  "hash": "7ca85bcc45e7d53106ea75b606ce2219bd37be7bb33588179cca6f1a26e5bb23"
+}
@@ -1,22 +0,0 @@
-{
-  "db_name": "PostgreSQL",
-  "query": "\n        SELECT EXISTS(\n            SELECT 1\n            FROM delphi_issue_details_with_statuses didws\n            INNER JOIN delphi_report_issues dri ON dri.id = didws.issue_id\n            WHERE\n                didws.project_id = $1\n                AND didws.status = 'pending'\n                -- see delphi.rs todo comment\n                AND dri.issue_type != '__dummy'\n        ) AS \"is_in_tech_review!\"\n        ",
-  "describe": {
-    "columns": [
-      {
-        "ordinal": 0,
-        "name": "is_in_tech_review!",
-        "type_info": "Bool"
-      }
-    ],
-    "parameters": {
-      "Left": [
-        "Int8"
-      ]
-    },
-    "nullable": [
-      null
-    ]
-  },
-  "hash": "8c80f3158fb5772adc8542cdf5419437bb8cd65723a32e587022d0c8decba68d"
-}
@@ -1,6 +1,6 @@
 {
  "db_name": "PostgreSQL",
-  "query": "\n        SELECT\n            didws.id AS \"id!: DelphiReportIssueDetailsId\",\n            didws.issue_id AS \"issue_id!: DelphiReportIssueId\",\n            didws.key AS \"key!: String\",\n            didws.jar AS \"jar?: String\",\n            didws.file_path AS \"file_path!: String\",\n            didws.data AS \"data!: sqlx::types::Json<HashMap<String, serde_json::Value>>\",\n            didws.severity AS \"severity!: DelphiSeverity\",\n            didws.status AS \"status!: DelphiStatus\"\n        FROM delphi_issue_details_with_statuses didws\n        WHERE didws.issue_id = ANY($1::bigint[])\n        ",
+  "query": "\n        SELECT\n            didws.id AS \"id!: DelphiReportIssueDetailsId\",\n            didws.issue_id AS \"issue_id!: DelphiReportIssueId\",\n            didws.key AS \"key!: String\",\n            didws.jar AS \"jar?: String\",\n            didws.file_path AS \"file_path!: String\",\n            didws.data AS \"data!: sqlx::types::Json<HashMap<String, serde_json::Value>>\",\n            didws.severity AS \"severity!: DelphiSeverity\",\n            didws.local_status AS \"local_status?: DelphiStatus\",\n            didws.global_status AS \"global_status?: DelphiStatus\",\n            didws.status AS \"status!: DelphiStatus\"\n        FROM delphi_issue_details_with_statuses didws\n        WHERE didws.issue_id = ANY($1::bigint[])\n        ",
  "describe": {
    "columns": [
      {
@@ -52,6 +52,38 @@
      },
      {
        "ordinal": 7,
+        "name": "local_status?: DelphiStatus",
+        "type_info": {
+          "Custom": {
+            "name": "delphi_report_issue_status",
+            "kind": {
+              "Enum": [
+                "pending",
+                "safe",
+                "unsafe"
+              ]
+            }
+          }
+        }
+      },
+      {
+        "ordinal": 8,
+        "name": "global_status?: DelphiStatus",
+        "type_info": {
+          "Custom": {
+            "name": "delphi_report_issue_status",
+            "kind": {
+              "Enum": [
+                "pending",
+                "safe",
+                "unsafe"
+              ]
+            }
+          }
+        }
+      },
+      {
+        "ordinal": 9,
        "name": "status!: DelphiStatus",
        "type_info": {
          "Custom": {
@@ -80,8 +112,10 @@
      true,
      true,
      true,
+      true,
+      true,
      true
    ]
  },
-  "hash": "951700c659d040068dae8e2f91b82b6a3af676439b47ff76d72000ddeca0e334"
+  "hash": "9070b1b6a5b1e93eb1fd1838c522fa6084ad6a5c86fafbfe8448ea7cc86f38ba"
 }
@@ -0,0 +1,22 @@
+{
+  "db_name": "PostgreSQL",
+  "query": "\n        SELECT DISTINCT didws.project_id AS \"project_id!: DBProjectId\"\n        FROM delphi_issue_details_with_statuses didws\n        WHERE didws.key = ANY($1::text[])\n        ",
+  "describe": {
+    "columns": [
+      {
+        "ordinal": 0,
+        "name": "project_id!: DBProjectId",
+        "type_info": "Int8"
+      }
+    ],
+    "parameters": {
+      "Left": [
+        "TextArray"
+      ]
+    },
+    "nullable": [
+      true
+    ]
+  },
+  "hash": "ba7585f55df2a4596caae265ac956eb23268f26aef664234b898b17d13c09f91"
+}
@@ -1,23 +0,0 @@
-{
-  "db_name": "PostgreSQL",
-  "query": "\n        SELECT EXISTS(\n            SELECT 1\n            FROM unnest($2::text[]) AS incoming(detail_key)\n            LEFT JOIN delphi_global_detail_verdicts dgdv\n                ON dgdv.detail_key = incoming.detail_key\n            LEFT JOIN delphi_issue_detail_verdicts didv\n                ON didv.project_id = $1 AND didv.detail_key = incoming.detail_key\n            WHERE dgdv.detail_key IS NULL AND didv.project_id IS NULL\n        ) AS \"has_unflagged_issue_details!\"\n        ",
-  "describe": {
-    "columns": [
-      {
-        "ordinal": 0,
-        "name": "has_unflagged_issue_details!",
-        "type_info": "Bool"
-      }
-    ],
-    "parameters": {
-      "Left": [
-        "Int8",
-        "TextArray"
-      ]
-    },
-    "nullable": [
-      null
-    ]
-  },
-  "hash": "bab0f71c84902bac7589a30923e95cbcd76d340c21ac6116d9bd27878786bd26"
-}
@@ -0,0 +1,60 @@
+{
+  "db_name": "PostgreSQL",
+  "query": "\n        WITH project_ids AS (\n            SELECT unnest($1::bigint[]) AS project_id\n        )\n        SELECT\n            p.project_id AS \"project_id!: DBProjectId\",\n            EXISTS(\n                SELECT 1\n                FROM delphi_issue_details_with_statuses didws\n                INNER JOIN delphi_report_issues dri ON dri.id = didws.issue_id\n                WHERE\n                    didws.project_id = p.project_id\n                    AND didws.status = 'pending'\n                    AND dri.issue_type != $3\n            ) AS \"has_pending_detail!\",\n            EXISTS(\n                SELECT 1\n                FROM delphi_issue_details_with_statuses didws\n                INNER JOIN delphi_report_issues dri ON dri.id = didws.issue_id\n                WHERE\n                    didws.project_id = p.project_id\n                    AND didws.status = 'unsafe'\n                    AND dri.issue_type != $3\n            ) AS \"has_unsafe_detail!\",\n            EXISTS(\n                SELECT 1\n                FROM delphi_issue_details_with_statuses didws\n                INNER JOIN delphi_report_issues dri ON dri.id = didws.issue_id\n                WHERE\n                    didws.project_id = p.project_id\n                    AND didws.status = 'pending'\n                    AND dri.issue_type = $3\n            ) AS \"has_dummy!\",\n            (\n                SELECT t.id\n                FROM threads t\n                WHERE t.mod_id = p.project_id\n                ORDER BY t.id\n                LIMIT 1\n            ) AS \"thread_id: DBThreadId\",\n            (\n                SELECT tm.body->>'type'\n                FROM threads t\n                INNER JOIN threads_messages tm ON tm.thread_id = t.id\n                WHERE\n                    t.mod_id = p.project_id\n                    AND tm.body->>'type' = ANY($2::text[])\n                ORDER BY tm.created DESC, tm.id DESC\n                LIMIT 1\n            ) AS \"last_tech_review_message_type\",\n            (\n                SELECT dr.id\n                FROM versions v\n                INNER JOIN files f ON f.version_id = v.id\n                INNER JOIN delphi_reports dr ON dr.file_id = f.id\n                WHERE v.mod_id = p.project_id\n                ORDER BY dr.created DESC, dr.id DESC\n                LIMIT 1\n            ) AS \"report_id: DelphiReportId\"\n        FROM project_ids p\n        ",
+  "describe": {
+    "columns": [
+      {
+        "ordinal": 0,
+        "name": "project_id!: DBProjectId",
+        "type_info": "Int8"
+      },
+      {
+        "ordinal": 1,
+        "name": "has_pending_detail!",
+        "type_info": "Bool"
+      },
+      {
+        "ordinal": 2,
+        "name": "has_unsafe_detail!",
+        "type_info": "Bool"
+      },
+      {
+        "ordinal": 3,
+        "name": "has_dummy!",
+        "type_info": "Bool"
+      },
+      {
+        "ordinal": 4,
+        "name": "thread_id: DBThreadId",
+        "type_info": "Int8"
+      },
+      {
+        "ordinal": 5,
+        "name": "last_tech_review_message_type",
+        "type_info": "Text"
+      },
+      {
+        "ordinal": 6,
+        "name": "report_id: DelphiReportId",
+        "type_info": "Int8"
+      }
+    ],
+    "parameters": {
+      "Left": [
+        "Int8Array",
+        "TextArray",
+        "Text"
+      ]
+    },
+    "nullable": [
+      null,
+      null,
+      null,
+      null,
+      null,
+      null,
+      null
+    ]
+  },
+  "hash": "bb94018c84f3809b9ad89f35ff08501addc8f203a0a152346aaebd32db52be30"
+}
@@ -1,6 +1,6 @@
 {
  "db_name": "PostgreSQL",
-  "query": "\n        SELECT\n            to_jsonb(dri)\n            || jsonb_build_object(\n                -- TODO: replace with `json_array` in Postgres 16\n                'details', (\n                    SELECT coalesce(jsonb_agg(\n                        jsonb_build_object(\n                            'id', didws.id,\n                            'issue_id', didws.issue_id,\n                            'key', didws.key,\n                            'file_path', didws.file_path,\n                            'decompiled_source', didws.decompiled_source,\n                            'data', didws.data,\n                            'severity', didws.severity,\n                            'status', didws.status\n                        )\n                    ), '[]'::jsonb)\n                    FROM delphi_issue_details_with_statuses didws\n                    WHERE didws.issue_id = dri.id\n                )\n            ) AS \"data!: sqlx::types::Json<FileIssue>\"\n        FROM delphi_report_issues dri\n        WHERE dri.id = $1\n        ",
+  "query": "\n        SELECT\n            to_jsonb(dri)\n            || jsonb_build_object(\n                -- TODO: replace with `json_array` in Postgres 16\n                'details', (\n                    SELECT coalesce(jsonb_agg(\n                        jsonb_build_object(\n                            'id', didws.id,\n                            'issue_id', didws.issue_id,\n                            'key', didws.key,\n                            'file_path', didws.file_path,\n                            'decompiled_source', didws.decompiled_source,\n                            'data', didws.data,\n                            'severity', didws.severity,\n                            'local_status', didws.local_status,\n                            'global_status', didws.global_status,\n                            'status', didws.status\n                        )\n                    ), '[]'::jsonb)\n                    FROM delphi_issue_details_with_statuses didws\n                    WHERE didws.issue_id = dri.id\n                )\n            ) AS \"data!: sqlx::types::Json<FileIssue>\"\n        FROM delphi_report_issues dri\n        WHERE dri.id = $1\n        ",
  "describe": {
    "columns": [
      {
@@ -18,5 +18,5 @@
      null
    ]
  },
-  "hash": "112bc4904c32afc9ffba30528a9c0e7b7fe259c58411afa5ef86a7ae4bde2703"
+  "hash": "c3598ed9f64f7151b83d47a15fabfdcf015bda1b3c0a7f2358c7f284feb532c3"
 }
@@ -0,0 +1,22 @@
+{
+  "db_name": "PostgreSQL",
+  "query": "\n        SELECT DISTINCT didws.project_id AS \"project_id!: DBProjectId\"\n        FROM delphi_issue_details_with_statuses didws\n        INNER JOIN delphi_report_issues dri ON dri.id = didws.issue_id\n        WHERE\n            didws.id = ANY($1::bigint[])\n            AND dri.issue_type != '__dummy'\n        ",
+  "describe": {
+    "columns": [
+      {
+        "ordinal": 0,
+        "name": "project_id!: DBProjectId",
+        "type_info": "Int8"
+      }
+    ],
+    "parameters": {
+      "Left": [
+        "Int8Array"
+      ]
+    },
+    "nullable": [
+      true
+    ]
+  },
+  "hash": "e3c356bd41074ba4b3474dfab5cc0349636abea5b21faf5fc18d9f69fd21db1d"
+}
@@ -0,0 +1,15 @@
+{
+  "db_name": "PostgreSQL",
+  "query": "\n        WITH dummy_issue AS (\n            INSERT INTO delphi_report_issues (report_id, issue_type)\n            VALUES ($1, $2)\n            ON CONFLICT (report_id, issue_type)\n            DO UPDATE SET issue_type = EXCLUDED.issue_type\n            RETURNING id\n        )\n        INSERT INTO delphi_report_issue_details (\n            issue_id,\n            key,\n            jar,\n            file_path,\n            decompiled_source,\n            data,\n            severity\n        )\n        SELECT\n            id,\n            '',\n            NULL,\n            '',\n            NULL,\n            '{}'::jsonb,\n            'low'::delphi_severity\n        FROM dummy_issue\n        WHERE NOT EXISTS (\n            SELECT 1\n            FROM delphi_report_issue_details drid\n            WHERE drid.issue_id = dummy_issue.id\n        )\n        ",
+  "describe": {
+    "columns": [],
+    "parameters": {
+      "Left": [
+        "Int8",
+        "Text"
+      ]
+    },
+    "nullable": []
+  },
+  "hash": "fc6c20348de487e4039ee7d53212ecd1856bde7aa4be6e366c98cef1321a7279"
+}