From ee60b1adbcc473ee28f2336108d69a976f60d82f Mon Sep 17 00:00:00 2001 From: Prospector <6166773+Prospector@users.noreply.github.com> Date: Tue, 28 Jul 2026 21:18:40 -0700 Subject: [PATCH] Replace final usage of legacy modal --- apps/frontend/src/components/ui/Modal.vue | 156 --------------- .../src/pages/settings/applications.vue | 72 ++++--- packages/ui/src/components/modal/Modal.vue | 184 ------------------ packages/ui/src/components/modal/index.ts | 1 - packages/ui/src/stories/add-stories.md | 8 +- 5 files changed, 38 insertions(+), 383 deletions(-) delete mode 100644 apps/frontend/src/components/ui/Modal.vue delete mode 100644 packages/ui/src/components/modal/Modal.vue diff --git a/apps/frontend/src/components/ui/Modal.vue b/apps/frontend/src/components/ui/Modal.vue deleted file mode 100644 index c6a9aa6657..0000000000 --- a/apps/frontend/src/components/ui/Modal.vue +++ /dev/null @@ -1,156 +0,0 @@ - - - - - - - {{ header }} - - - - - - - - - - - - - - - - - - diff --git a/apps/frontend/src/pages/settings/applications.vue b/apps/frontend/src/pages/settings/applications.vue index 1fb9c6950c..cf85773eb8 100644 --- a/apps/frontend/src/pages/settings/applications.vue +++ b/apps/frontend/src/pages/settings/applications.vue @@ -7,10 +7,10 @@ :proceed-label="formatMessage(messages.deleteConfirmButton)" @proceed="removeApp(editingId)" /> - - - {{ formatMessage(messages.nameLabel) }} + + + + {{ formatMessage(messages.nameLabel) }} - {{ formatMessage(messages.iconLabel) }} + + {{ formatMessage(messages.iconLabel) }} @@ -36,8 +40,8 @@ - - {{ formatMessage(messages.urlLabel) }} + + {{ formatMessage(messages.urlLabel) }} - - {{ formatMessage(messages.descriptionLabel) }} + + {{ formatMessage(messages.descriptionLabel) }} - {{ formatMessage(messages.scopesLabel) }} + + {{ formatMessage(messages.scopesLabel) }} - + - + {{ category.name }} @@ -83,8 +88,8 @@ - {{ formatMessage(messages.redirectUrisLabel) }} + + {{ formatMessage(messages.redirectUrisLabel) }} @@ -93,6 +98,7 @@ v-model="redirectUris[index]" :maxlength="2048" type="url" + class="w-80" autocomplete="off" :placeholder="formatMessage(messages.redirectUriPlaceholder)" /> @@ -116,18 +122,20 @@ + - + + - {{ formatMessage(messages.cancel) }} + {{ formatMessage(commonMessages.cancelButton) }} - {{ formatMessage(messages.saveChanges) }} + {{ formatMessage(commonMessages.saveChangesButton) }} @@ -137,8 +145,8 @@ - - + + @@ -220,7 +228,7 @@ " > - {{ formatMessage(messages.edit) }} + {{ formatMessage(commonMessages.editButton) }} @@ -255,6 +263,7 @@ import { injectModrinthClient, injectNotificationManager, IntlFormatted, + NewModal, normalizeChildren, StyledInput, useFormatDateTime, @@ -262,7 +271,6 @@ import { } from '@modrinth/ui' import { useQuery } from '@tanstack/vue-query' -import Modal from '~/components/ui/Modal.vue' import { getScopeValue, hasScope, @@ -355,14 +363,6 @@ const messages = defineMessages({ id: 'settings.applications.button.add-redirect-uri', defaultMessage: 'Add a redirect URI', }, - cancel: { - id: 'settings.applications.button.cancel', - defaultMessage: 'Cancel', - }, - saveChanges: { - id: 'settings.applications.button.save-changes', - defaultMessage: 'Save changes', - }, createApp: { id: 'settings.applications.button.create', defaultMessage: 'Create app', @@ -396,10 +396,6 @@ const messages = defineMessages({ id: 'settings.applications.created-on', defaultMessage: 'Created on {date}', }, - edit: { - id: 'settings.applications.button.edit', - defaultMessage: 'Edit', - }, delete: { id: 'settings.applications.button.delete', defaultMessage: 'Delete', diff --git a/packages/ui/src/components/modal/Modal.vue b/packages/ui/src/components/modal/Modal.vue deleted file mode 100644 index c3fa0f4089..0000000000 --- a/packages/ui/src/components/modal/Modal.vue +++ /dev/null @@ -1,184 +0,0 @@ - - - (closable ? hide() : {})" - /> - (closable ? hide() : {})" - /> - - - - {{ props.header }} - - - - - - - - - - - - - - - - diff --git a/packages/ui/src/components/modal/index.ts b/packages/ui/src/components/modal/index.ts index d85ee9c88a..4f27f8c31c 100644 --- a/packages/ui/src/components/modal/index.ts +++ b/packages/ui/src/components/modal/index.ts @@ -1,6 +1,5 @@ export { default as ConfirmLeaveModal } from './ConfirmLeaveModal.vue' export { default as ConfirmModal } from './ConfirmModal.vue' -export { default as Modal } from './Modal.vue' export { default as NewModal } from './NewModal.vue' export type { ServerProject as OpenInAppModalServerProject } from './OpenInAppModal.vue' export { default as OpenInAppModal } from './OpenInAppModal.vue' diff --git a/packages/ui/src/stories/add-stories.md b/packages/ui/src/stories/add-stories.md index 04b775ea5a..19f83c3ba9 100644 --- a/packages/ui/src/stories/add-stories.md +++ b/packages/ui/src/stories/add-stories.md @@ -153,9 +153,9 @@ For components that need user interaction to show: ```typescript export const Default: Story = { render: () => ({ - components: { Modal, ButtonStyled }, + components: { NewModal, ButtonStyled }, setup() { - const modalRef = ref | null>(null) + const modalRef = ref | null>(null) return { modalRef } }, template: /* html */ ` @@ -163,9 +163,9 @@ export const Default: Story = { Open Modal - + Modal content - + `, }),
Modal content