fix: post-release shared instances (#6860)

* fix: qa

* fix: lint
This commit is contained in:
Calum H.
2026-07-24 17:54:00 +00:00
committed by GitHub
parent 5e155d69b6
commit cc0d3bf42c
5 changed files with 16 additions and 18 deletions
@@ -11,9 +11,9 @@
clearable clearable
/> />
<template v-if="!actionsLocked"> <template v-if="!actionsLocked">
<ButtonStyled> <ButtonStyled type="outlined">
<button <button
class="flex !h-10 shrink-0 items-center gap-2" class="flex !h-10 shrink-0 items-center gap-2 !border"
:disabled="pushUpdateDisabled" :disabled="pushUpdateDisabled"
@click="emit('push-update', $event)" @click="emit('push-update', $event)"
> >
@@ -147,15 +147,15 @@ const messages = defineMessages({
}, },
benefitJoin: { benefitJoin: {
id: 'modal.shared-instance.open-in-app.benefit.join', id: 'modal.shared-instance.open-in-app.benefit.join',
defaultMessage: 'Join the shared instance in one click', defaultMessage: 'Play the same content as your friends',
}, },
benefitInstall: { benefitInstall: {
id: 'modal.shared-instance.open-in-app.benefit.install', id: 'modal.shared-instance.open-in-app.benefit.install',
defaultMessage: 'Automatically install the required game and loader', defaultMessage: 'Automatically install everything theyre playing',
}, },
benefitUpdate: { benefitUpdate: {
id: 'modal.shared-instance.open-in-app.benefit.update', id: 'modal.shared-instance.open-in-app.benefit.update',
defaultMessage: 'Keep shared content updated when the instance changes', defaultMessage: 'Keep shared content up to date as it changes',
}, },
openingAutomatically: { openingAutomatically: {
id: 'modal.shared-instance.open-in-app.opening-automatically', id: 'modal.shared-instance.open-in-app.opening-automatically',
@@ -123,7 +123,10 @@
{{ report.version.files.find((f) => f.primary)?.filename || 'Unknown Version' }} {{ report.version.files.find((f) => f.primary)?.filename || 'Unknown Version' }}
</span> </span>
<span <span
v-if="report.item_type === 'shared-instance' && report.shared_instance_version_id" v-if="
report.item_type === 'shared-instance' &&
report.shared_instance_version_id !== undefined
"
class="text-sm text-secondary" class="text-sm text-secondary"
> >
Version {{ report.shared_instance_version_id }} Version {{ report.shared_instance_version_id }}
@@ -520,9 +523,10 @@ async function loadSharedInstanceDetails() {
} }
const reportedVersion = props.report.shared_instance_version_id const reportedVersion = props.report.shared_instance_version_id
const versionNumbers = reportedVersion const versionNumbers =
? Array.from({ length: reportedVersion }, (_, index) => reportedVersion - index) reportedVersion !== undefined
: [] ? Array.from({ length: reportedVersion + 1 }, (_, index) => reportedVersion - index)
: []
const [versionDetails, otherInstancesResult] = await Promise.all([ const [versionDetails, otherInstancesResult] = await Promise.all([
Promise.all( Promise.all(
versionNumbers.map(async (versionNumber) => { versionNumbers.map(async (versionNumber) => {
+3 -3
View File
@@ -2928,13 +2928,13 @@
"message": "Email verification required" "message": "Email verification required"
}, },
"modal.shared-instance.open-in-app.benefit.install": { "modal.shared-instance.open-in-app.benefit.install": {
"message": "Automatically install the required game and loader" "message": "Automatically install everything theyre playing"
}, },
"modal.shared-instance.open-in-app.benefit.join": { "modal.shared-instance.open-in-app.benefit.join": {
"message": "Join the shared instance in one click" "message": "Play the same content as your friends"
}, },
"modal.shared-instance.open-in-app.benefit.update": { "modal.shared-instance.open-in-app.benefit.update": {
"message": "Keep shared content updated when the instance changes" "message": "Keep shared content up to date as it changes"
}, },
"modal.shared-instance.open-in-app.get-app": { "modal.shared-instance.open-in-app.get-app": {
"message": "Get Modrinth App" "message": "Get Modrinth App"
@@ -217,12 +217,6 @@ function expandedCardPosition(index: number) {
function cardPosition(index: number) { function cardPosition(index: number) {
const position = isExpanded.value ? expandedCardPosition(index) : collapsedCardPosition(index) const position = isExpanded.value ? expandedCardPosition(index) : collapsedCardPosition(index)
const item = props.items[index] const item = props.items[index]
if (index === 0 && singleItemEntrance.value) {
return {
...position,
opacity: 0,
}
}
if (!item || !enteringItemIds.value.has(item.id)) return position if (!item || !enteringItemIds.value.has(item.id)) return position
return { return {